quick fix for undefined caused by images.

'pepper/andrewsutherland/outclicks/script.php' at line 77.

replace

        path += "?outclick="+esc(elem.href);

to

        if(elem.nodeName == 'IMG') {
            path += "?outclick="+esc(elem.parentNode.href);
        } else {
            path += "?outclick="+esc(elem.href);
        }

That should fix all.
IE and Firefox are now showing proper urls.

This is for Outclicks 1.14

-janisto

Are you guys referring to records with "undefined" as the title? With the above fix I still have completely empty, i.e. "", outclicks. Anyone else seeing this?

I had discovered the same issue; I applied the fix mentioned above and it solved the issue.

the "undefined" outclicks are now the majority of my outclicks..
i don't know what's wrong..

i noticed it's happening on two pages:
on one of those i have two links relating to the same page like these:

<a href="/section/#subsection1">link</a>

and on the other one i have few links that open in new window, i'm using javascript there:

<a href="http://example.com" onclick="window.open(this.href); return false;"><link</a>

but there are links like these on other pages too, and there were no undefined...

i'm not sure what might be wrong. if anyone has an idea let me know please
waiting for 1.15

cheers

Hmm - I'm still getting an 'undefined' after applying the patch.

Only seems to come from one page - I'm going to investigate further and see which link is triggering this.

CL

janisto wrote:

That should fix all.
IE and Firefox are now showing proper urls.

This is for Outclicks 1.14

-janisto

Thank you, that worked perfectly.

Hi,
I think window.open is the reason.

Try removing this kind of links:
<a href='http://www.lisa.org/' onclick='window.open(this.href); return false;'>LISA</a>

If you use window.open just to validate your site strict, try using something like this instead:
http://pure-essence.net/archives/2006/0 … lexternal/

or use just target="_blank".

-janisto

I just did a fresh install of Mint 1.29, outclicks, and much more pepper. Everything is working fine except one external link was showing up as undefined in outclicks.

I tried the fix that janisto suggested... although it didn't work because it is looking for the img tag. The link which was causing my undefined had a span tag in it.

<a href="http://worknet.wisconsin.gov/worknet/"><span class="caps">WORK</span>net</a>

So i just changed his fix to this

if(elem.nodeName == 'SPAN') {
            path += "?outclick="+esc(elem.parentNode.href);
        } else {
            path += "?outclick="+esc(elem.href);
        }

and it works now.

The two links shown here are the same link. One before the fix and one after.



So obviously the code needs something to allow for tags that are within the <a> element.

A better fix (for the people above) would be:

        if(elem.parentNode && elem.parentNode.href) {
            path += "?outclick="+esc(elem.parentNode.href);
        } else {
            path += "?outclick="+esc(elem.href);
        }